Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrates Borg Gripper to New Attack Chain, Fixes Some Bugs #28139

Merged
merged 5 commits into from
Jan 31, 2025

Conversation

Fordoxia
Copy link
Contributor

@Fordoxia Fordoxia commented Jan 26, 2025

What Does This PR Do

Why It's Good For The Game

Attack chain migration good.
Makes the gripper compatible with new attack chain.
Bug fixes good.

Testing

Became engiborg.
Assembled fire alarm*, air alarm, APC, extinguisher cabinet, defib mount, charger, and computer from components to completion.
Attacked scientific analyser with and without items held, behaviour remains the same as before migration.
Removed cell and added cell back into charger and APC.

Became mining borg.
Checked I could still grab goliath plates and armour myself with them.

Became service borg.
Checked I could still give people cigarettes
Checked I could help people up from the floor.
Petted Ian, tried to pet a juggernaut, hugged punpun.

*fire alarm required code alterations, atomised into #28136.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
fix: Grippers can place light tiles again.
fix: Grippers can place cells into chargers and APCs again.
fix: Grippers no longer bap machines when inserting held items into them.
fix: Grippers no longer pet animals 2 times with one attack.
/:cl:

@Fordoxia Fordoxia changed the title Creation Migrates Borg Gripper to New Attack Chain, Fixes Some Bugs Jan 26, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Jan 26, 2025
@1080pCat 1080pCat added Fix This PR will fix an issue in the game Attack Chain Migration Refactoring of legacy attack chain items labels Jan 28, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 30, 2025
@Cress67
Copy link
Contributor

Cress67 commented Jan 31, 2025

Please god merge this as quickly as possible, not being able to fix APCs or Fire Alarms or Air Alarms that get smashed by demons/biohazards/explosives is hell.

@Burzah Burzah added this pull request to the merge queue Jan 31, 2025
Merged via the queue into ParadiseSS13:master with commit 6ef209d Jan 31, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Attack Chain Migration Refactoring of legacy attack chain items Fix This PR will fix an issue in the game
Projects
None yet
6 participants